Eth secpm splitted #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemenkina
approved these changes
Sep 3, 2024
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
kaiserd
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Thank you.
This is the first part of my review. Will do another pass.
See my comments inline.
Main issues are:
- it seems hard to follow for an uninitiated implementer
- a theory / protocol flow section before the technical spec would help readers (see RFC template)
- please make more explicit which parts we added and which parts refer to existing specs (MLS, SIWE)
- especially in the SIWE part
- onchain component is under specified, needs more detail
- should mention centralized parts in SIWE including arguments how we plan to get past that in future versions (for now we can blackbox this)
Also, please fix the linter issues.
Improved section on onchain components. In particular, improved the description of addition of users and updates.
Co-authored-by: kaiserd <[email protected]>
Co-authored-by: kaiserd <[email protected]>
Co-authored-by: kaiserd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains 2 new RFCs: