This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
14-WAKU2-MESSAGE: Adds security consideration about the timestamp field #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarth
reviewed
Aug 5, 2021
oskarth
reviewed
Aug 5, 2021
Co-authored-by: oskarth <[email protected]>
Co-authored-by: oskarth <[email protected]>
oskarth
approved these changes
Aug 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add an explainer about the security issues related to sender-generated timestamps in waku messages.
For more context please see #440
I have also used the PR to revise the discussion about the encryption and signature usage in the waku message and add a link to the recent rfc-26.