Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

update: RFC 51 static sharding #576

Merged
merged 1 commit into from
Feb 23, 2023
Merged

update: RFC 51 static sharding #576

merged 1 commit into from
Feb 23, 2023

Conversation

kaiserd
Copy link
Contributor

@kaiserd kaiserd commented Feb 23, 2023

This RFC addresses part of vacp2p/research#174

@kaiserd kaiserd requested a review from jm-clius February 23, 2023 11:30
jm-clius
jm-clius approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We may want to RECOMMEND in the WAKU-ENR spec that nodes should limit the number of multiaddrs they encode if also supporting static sharding. They should rather use discovery methods more appropriate to multiaddrs (to be defined, but e.g. rendezvous).

@kaiserd
Copy link
Contributor Author

kaiserd commented Feb 23, 2023

Yes. Thank you.
I'll add limiting number of multiaddrs to the ENR PR :).

@kaiserd kaiserd merged commit f525f99 into master Feb 23, 2023
@kaiserd kaiserd deleted the update/rfc-51-sharding branch February 23, 2023 12:48
@kaiserd kaiserd mentioned this pull request Mar 3, 2023
Closed
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jm-clius jm-clius jm-clius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiserd @jm-clius