refactor(RewardsStreamerMP): use Math.mulDiv to reduce likelyhood of
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
refactor/muldiv
branch
from
6fa11e3 to
b621485
Compare
This was referenced Dec 4, 2024
0x-r4bbit
commented
Dec 4, 2024
src/RewardsStreamerMP.sol
Outdated
| return amount * lockMultiplier / SCALE_FACTOR; | ||
| return Math.mulDiv( | ||
| Math.mulDiv(amount * lockPeriod, MAX_MULTIPLIER * SCALE_FACTOR, MAX_LOCKUP_PERIOD), 1, SCALE_FACTOR | ||
| ); |
There was a problem hiding this comment.
This can be changed to
uint256 intermediate = Math.mulDiv(amount * lockPeriod, MAX_MULTIPLIER * SCALE_FACTOR, MAX_LOCKUP_PERIOD);
return intermediate / SCALE_FACTOR;
3esmit
previously requested changes
Dec 5, 2024
| @@ -444,7 +447,7 @@ contract RewardsStreamerMP is | |||
| return 0; | |||
| } | |||
|
|
|||
| uint256 accruedMP = (timeDiff * account.stakedBalance * MP_RATE_PER_YEAR) / (365 days * SCALE_FACTOR); | |||
There was a problem hiding this comment.
You need to remove scale factor if using math.muldiv
0x-r4bbit
force-pushed
the
refactor/muldiv
branch
from
b621485 to
2dee933
Compare
precision loss Closes #85
0x-r4bbit
force-pushed
the
refactor/muldiv
branch
from
bfa5879 to
7aefe4c
Compare
|
@3esmit this is now green on CI. I'm dismissing your "change requested" as all the requested changes have landed and it keeps us blocked from merging this. |
0x-r4bbit
dismissed
3esmit’s stale review
We agreed on merging this once green on CI
3esmit
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precision loss
Closes #85
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?