-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: integration of new bitbox API #1415
Feat: integration of new bitbox API #1415
Conversation
9dd4316
to
8432467
Compare
Hi @refi93, BitBox firmware dev here. If it is required to withdraw staking funds, we will support it. Any suggestions for how to test such a change before it is live? Would you potentially be interested in helping us to add support in the BitBox02 firmware? It could be more efficient as you will be more familiar with the details. There is a simulator for easy testing. Protobuf certificate definitions: Certificate verification code: called from the main transaction verification/processing function: |
@benma For the sake of inspiration/test vectors I'd recommend checking the ledger JS library integration tests which include also transactions with vote delegations and other new kinds of certificates: https://github.com/vacuumlabs/ledgerjs-cardano-shelley/blob/9c643c406ed200e44b56e8349ec2ac3c53b670de/test/integration/__fixtures__/signTx.ts#L758 here's Ledger's cardano app source code: https://github.com/LedgerHQ/app-cardano/blob/605d7095d9d40cc04b18cb398a163d50e0215afd/src/signTx.c#L1101 additionally, here's trezor firmware PR adding conway functionality: https://github.com/trezor/trezor-firmware/pull/3496/files regarding possible assistance with development, we'll discuss internally and get back to you in the upcoming 1-2 days 👍 |
Co-authored-by: Rafael Korbaš <[email protected]>
Addresses issue: #1406