Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mnemonicAuth into hooks, remove unnecessary keys from state #942

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Refactor mnemonicAuth into hooks, remove unnecessary keys from state #942

merged 2 commits into from
Apr 12, 2021

Conversation

xdzurman
Copy link
Contributor

@xdzurman xdzurman commented Apr 8, 2021

No description provided.

@mlenik mlenik temporarily deployed to adalite-refactor-state--ml9pco April 8, 2021 09:16 Inactive
@xdzurman xdzurman temporarily deployed to adalite-refactor-state--ml9pco April 8, 2021 09:30 Inactive
@xdzurman xdzurman added the needs review PR waiting to be reviewed label Apr 8, 2021
@xdzurman
Copy link
Contributor Author

xdzurman commented Apr 8, 2021

This PR was also supposed to remove mnemonicAuthForm from State, more in #943

@izri16 izri16 added needs work and removed needs review PR waiting to be reviewed labels Apr 9, 2021
@xdzurman xdzurman temporarily deployed to adalite-refactor-state--ml9pco April 12, 2021 06:32 Inactive
@xdzurman xdzurman temporarily deployed to adalite-refactor-state--ml9pco April 12, 2021 06:40 Inactive
@xdzurman xdzurman added needs review PR waiting to be reviewed and removed needs work labels Apr 12, 2021
@xdzurman xdzurman requested a review from izri16 April 12, 2021 06:41
@xdzurman xdzurman temporarily deployed to adalite-refactor-state--ml9pco April 12, 2021 06:59 Inactive
@izri16 izri16 removed the needs review PR waiting to be reviewed label Apr 12, 2021
@xdzurman xdzurman merged commit 0fc0717 into develop Apr 12, 2021
@xdzurman xdzurman deleted the Refactor-state-2 branch April 12, 2021 07:53
@xdzurman xdzurman temporarily deployed to adalite-staging April 12, 2021 07:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izri16 izri16 izri16 approved these changes

@PeterBenc PeterBenc Awaiting requested review from PeterBenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xdzurman @izri16 @mlenik