Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging with onflow latest development branch #2

Merged
merged 47 commits into from
Aug 6, 2024

Merge pull request #3 from vacuumlabs/audit_findings

0c12067
Select commit
Loading
Failed to load commit list.
Merged

Merging with onflow latest development branch #2

Merge pull request #3 from vacuumlabs/audit_findings
0c12067
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jun 12, 2024 in 4s

32 new alerts

New alerts in code changed by this pull request

  • 5 warnings
  • 27 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 81 in deps/ledger-zxlib/app/ui/view_inspect_x.c

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 51 in deps/ledger-zxlib/app/ui/view_inspect_x.c

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 38 in deps/ledger-zxlib/include/zxmacros.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1252 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 1219 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 762 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 528 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 369 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 70 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable shortcut_value is never read.

Check notice on line 69 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable shortcut_key is never read.

Check notice on line 67 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_configvalue is never read.

Check notice on line 66 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_keyconfig is never read.

Check notice on line 65 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_addrvalue is never read.

Check notice on line 64 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_txvalue is never read.

Check notice on line 63 in deps/ledger-zxlib/app/ui/view_internal.h

See this annotation in the file changed.

Code scanning / CodeQL

Unused static variable Note

Static variable review_key is never read.

Check notice on line 24 in deps/ledger-zxlib/src/buffering.c

See this annotation in the file changed.

Code scanning / CodeQL

Short global name Note

Poor global variable name 'ram'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo).

Check notice on line 1482 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1497 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1503 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1316 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1331 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check notice on line 1337 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.

Check warning on line 1476 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 165 lines.

Check warning on line 1310 in deps/ledger-zxlib/include/utf8.h

See this annotation in the file changed.

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 165 lines.

Check warning on line 468 in deps/ledger-zxlib/src/timeutils.c

See this annotation in the file changed.

Code scanning / CodeQL

Year field changed using an arithmetic operation without checking for leap year Warning

Field
tm_year
Loading
on variable
date
Loading
has been modified, but no appropriate check for LeapYear was found.