Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app split (XS app) #195

Closed
wants to merge 2 commits into from
Closed

app split (XS app) #195

wants to merge 2 commits into from

Conversation

janmazak
Copy link
Collaborator

No description provided.

@janmazak janmazak marked this pull request as ready for review September 6, 2023 12:26
davidmisiak
davidmisiak approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@davidmisiak davidmisiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comment suggestions. If all tests are passing on both app builds, LGTM. I haven't done any manual testing.

src/interactions/signTx.ts Show resolved Hide resolved
src/interactions/signTx.ts Show resolved Hide resolved
src/interactions/serialization/txInit.ts Show resolved Hide resolved
test/integration/getVersion.test.ts Show resolved Hide resolved
test/integration/signOperationalCertificate.test.ts Show resolved Hide resolved
@janmazak janmazak force-pushed the appsplit branch 2 times, most recently from 860f4a5 to e329e7b Compare September 18, 2023 11:21
@janmazak
Copy link
Collaborator Author

janmazak commented Jan 9, 2024

Will be merged via #202

@janmazak janmazak closed this Jan 9, 2024
@janmazak janmazak deleted the appsplit branch January 17, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmisiak davidmisiak davidmisiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janmazak @davidmisiak