Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Desmo module #21

Closed
wants to merge 1 commit into from
+3 −7
Closed

Refactor Desmo module #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/lib/desmo-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ export class Desmo {
private abiInterface: ethers.utils.Interface;

private iexec?: IExec;
private readonly callback: string = contractAddress;
private readonly category: number;
private dealId: string;
private readonly category = 0;
private dealId = '';

/**
*
Expand Down Expand Up @@ -52,9 +51,6 @@ export class Desmo {
throw new Error('Desmo Contract could not connect with iExec');
}
}

this.category = 0;
this.dealId = '';
}

/**
Expand Down Expand Up @@ -221,7 +217,7 @@ await desmoContract.buyQuery(
// TODO: understand why the callback is needed and why the typing is wrong
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
callback: this.callback,
callback: contractAddress,
});

const requestOrder = await this.iexec.order.signRequestorder(
Expand Down