Skip to content

Commit

Permalink
Syntax clean up. Bumped version.
Browse files Browse the repository at this point in the history
  • Loading branch information
valdetero committed Jun 26, 2015
1 parent 6c36972 commit 7ddff81
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 14 deletions.
4 changes: 2 additions & 2 deletions SevenDays.Core/Services/AkavacheCacheService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public async Task RemoveObject(string key)
{
return await BlobCache.LocalMachine.GetObject<T>(key);
}
catch (KeyNotFoundException exception)
catch (KeyNotFoundException)
{
return default(T);
}
Expand All @@ -52,7 +52,7 @@ public async Task<IEnumerable<T>> GetAllObjects<T>()
{
return await BlobCache.LocalMachine.GetAllObjects<T>();
}
catch (KeyNotFoundException exception)
catch (KeyNotFoundException)
{
return new List<T>();
}
Expand Down
8 changes: 5 additions & 3 deletions SevenDays.Core/ViewModels/ServerListViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,15 @@ public async Task ExecuteGetServersCommand()
Servers = new ObservableCollection<ServerViewModel>(servers);
}

/*
private RelayCommand checkConnectivityCommand;
public ICommand CheckConnectivityCommand
{
get { return checkConnectivityCommand ?? (checkConnectivityCommand = new RelayCommand(async () => await ExecuteCheckConnectivityCommand())); }
}
[Insights]
public async Task<bool> ExecuteCheckConnectivityCommand()
public Task<bool> ExecuteCheckConnectivityCommand()
{
throw new NotImplementedException();
}
Expand All @@ -66,7 +67,7 @@ public ICommand DeleteServerCommand
}
[Insights]
public async Task<bool> ExecuteDeleteServerCommand()
public Task<bool> ExecuteDeleteServerCommand()
{
throw new NotImplementedException();
}
Expand All @@ -78,9 +79,10 @@ public ICommand AddServerCommand
}
[Insights]
public async Task<bool> ExecuteAddServerCommand()
public Task<bool> ExecuteAddServerCommand()
{
throw new NotImplementedException();
}
*/
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:installLocation="auto" package="SevenDays.SevenDays" android:versionCode="2" android:versionName="1.1.0.0">
<manifest xmlns:android="http://schemas.android.com/apk/res/android" android:installLocation="auto" package="SevenDays.SevenDays" android:versionCode="4" android:versionName="1.3.0.0">
<uses-sdk android:targetSdkVersion="21" android:minSdkVersion="16" />
<application android:icon="@drawable/icon" android:label="SevenDays">
<meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Deployment xmlns="http://schemas.microsoft.com/windowsphone/2012/deployment" AppPlatformVersion="8.0">
<DefaultLanguage xmlns="" code="en-US" />
<App xmlns="" ProductID="{fcc1ddfa-63d0-438c-96c4-abda921b4b15}" Title="7 Days" RuntimeType="Silverlight" Version="1.1.0.0" Genre="apps.normal" Author="Seth Valdetero" Description="Sample description" Publisher="Sparkhound" PublisherID="{4d7b9a36-196a-49c7-920f-ee1fe9ba84a2}">
<App xmlns="" ProductID="{fcc1ddfa-63d0-438c-96c4-abda921b4b15}" Title="7 Days" RuntimeType="Silverlight" Version="1.3.0.0" Genre="apps.normal" Author="Seth Valdetero" Description="Sample description" Publisher="Sparkhound" PublisherID="{4d7b9a36-196a-49c7-920f-ee1fe9ba84a2}">
<IconPath IsRelative="true" IsResource="false">Assets\Icon.png</IconPath>
<Capabilities>
<Capability Name="ID_CAP_NETWORKING" />
Expand Down
12 changes: 8 additions & 4 deletions SevenDays.UI/SevenDays.UI.iOS/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,21 @@
<key>CFBundleIdentifier</key>
<string>com.sparkhound.SevenDays.UI</string>
<key>CFBundleVersion</key>
<string>1.0</string>
<string>1.3</string>
<key>CFBundleIconFiles</key>
<array>
<string>[email protected]</string>
<string>[email protected]</string>
<string>[email protected]</string>
<string>Default.png</string>
<string>[email protected]</string>
<string>[email protected]</string>
<string>Default-Portrait.png</string>
<string>[email protected]</string>
<string>[email protected]</string>
<string>[email protected]</string>
</array>
<key>UILaunchStoryboardName</key>
<string>LaunchScreen</string>
<key>CFBundleShortVersionString</key>
<string>1.1.0.0</string>
<string>1.3.0.0</string>
</dict>
</plist>
4 changes: 2 additions & 2 deletions SevenDays.UI/SevenDays.UI/Templates/ServerCell.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public ServerCell()
var favoriteAction = new MenuItem { Text = "Favorite" };
favoriteAction.SetBinding(MenuItem.CommandParameterProperty, new Binding("."));
favoriteAction.SetBinding<ServerViewModel>(MenuItem.CommandProperty, x => x.SetDefaultCommand);
favoriteAction.Clicked += async (sender, e) =>
favoriteAction.Clicked += (sender, e) =>
{
var mi = (MenuItem)sender;
var vm = (ServerViewModel)mi.CommandParameter;
Expand All @@ -26,7 +26,7 @@ public ServerCell()
var deleteAction = new MenuItem { Text = "Delete", IsDestructive = true };
deleteAction.SetBinding(MenuItem.CommandParameterProperty, new Binding("."));
deleteAction.SetBinding<ServerViewModel>(MenuItem.CommandProperty, x => x.DeleteCommand);
deleteAction.Clicked += async (sender, e) =>
deleteAction.Clicked += (sender, e) =>
{
var mi = (MenuItem)sender;
var vm = (ServerViewModel)mi.CommandParameter;
Expand Down
2 changes: 1 addition & 1 deletion SevenDays.UI/SevenDays.UI/Views/ServerListPage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ protected override async void OnAppearing()
await DependencyService.Get<IToastNotificator>().Notify(ToastNotificationType.Warning, "No Favorite", "Please select a favorite", TimeSpan.FromSeconds(3));
}
});
MessagingCenter.Subscribe<ServerCell, ServerViewModel>(this, "Favorite", async (sender, arg) =>
MessagingCenter.Subscribe<ServerCell, ServerViewModel>(this, "Favorite", (sender, arg) =>
{
foreach (var server in ViewModel.Servers)
{
Expand Down

0 comments on commit 7ddff81

Please sign in to comment.