Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the mdoc checked docs to use ember instead of blaze.
This is a continuation of http4s#4932 and http4s#4279.
Everything is rebased on latest
series/0.23
, but I can change the target branch if desired.I have introduced three changes that are worth calling out as they may be controversial.
Sleeping after ember server start
Starting the ember server in mdoc now looks like:
Without an
IO.sleep
, any attempt to connect to the ember server would fail with ajava.net.ConnectException: Connection refused
as the request would be attempted before the ember server was actually bound to the address.Adding logback to docs/mdoc
This was absolutely crucial for me to figure out what was going on with the connect refusal error above.
With logging enable I could see the
ConnectException
and then a second later the ember server log:I think having the logs is worthwhile if someone is running
mdoc
, it gives us slightly more visibility into what is going on.I stole the
logback.xml
from the gitter8 template.Forking mdoc
This is really just the workaround described in scalameta/mdoc#613 to avoid terminating sbt when mdoc fails.
Ditching
nest
mdoc modifierI've removed
nest
mdoc modifiers in client.md because I found they only added confusion.I've held off removing
nest
from the other docs as it turned out to not be necessary, but I feel like it's still worthwhile.I don't think it buys us much.