-
Notifications
You must be signed in to change notification settings - Fork 61
Add multicloud federated learning parttern #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Meng Yan <[email protected]>
Signed-off-by: Meng Yan <[email protected]>
This is an automated message: You can preview this docs PR at http://570.docs-pr.validatedpatterns.io |
Hi @yanmxa. Thanks for your PR. I'm waiting for a validatedpatterns member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Meng Yan <[email protected]>
Signed-off-by: Meng Yan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yanmxa, Thank you for your PR.
I have review the content for some basics style and syntax requirements based on IBM Style and Red Hat Supplementary guides.
Let me know if you have any questions.
install: getting-started | ||
help: https://groups.google.com/g/validatedpatterns | ||
bugs: https://github.com/open-cluster-management-io/addon-contrib/issues | ||
ci: multicloudfederatedlearning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we have CI set up for this. Kindly check this with the Validated Patterns engineering team
cc: @day0hero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlabonte-rh @yukinchan - what do we need to do to get this into 'testing' ?
content/patterns/multicloud-federated-learning/getting-started.adoc
Outdated
Show resolved
Hide resolved
content/patterns/multicloud-federated-learning/getting-started.adoc
Outdated
Show resolved
Hide resolved
content/patterns/multicloud-federated-learning/getting-started.adoc
Outdated
Show resolved
Hide resolved
content/patterns/multicloud-federated-learning/getting-started.adoc
Outdated
Show resolved
Hide resolved
content/patterns/multicloud-federated-learning/getting-started.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Avani Bhatt <[email protected]>
Co-authored-by: Avani Bhatt <[email protected]>
Co-authored-by: Avani Bhatt <[email protected]>
Co-authored-by: Avani Bhatt <[email protected]>
….adoc Co-authored-by: Avani Bhatt <[email protected]>
….adoc Co-authored-by: Avani Bhatt <[email protected]>
….adoc Co-authored-by: Avani Bhatt <[email protected]>
….adoc Co-authored-by: Avani Bhatt <[email protected]>
….adoc Co-authored-by: Avani Bhatt <[email protected]>
Hi @abhatt-rh, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yanmxa,
I am sorry I might be missing something, but I do not see a bunch of comments addressed. I have pointed out just two but there are others too. If there's a reason to skip them, please share; else please consider incorporating them. Thanks!
|
||
=== Why Use Advanced Cluster Management for Federated Learning? | ||
|
||
**Advanced Cluster Management (ACM)** simplifies and automates the deployment and orchestration of Federated Learning (FL) workloads across clusters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the bullet got mistakenly deleted from my earlier comment
**Advanced Cluster Management (ACM)** simplifies and automates the deployment and orchestration of Federated Learning (FL) workloads across clusters: | |
- **Advanced Cluster Management (ACM)** simplifies and automates the deployment and orchestration of Federated Learning (FL) workloads across clusters: |
|
||
=== Benefits | ||
|
||
- 🔒 Privacy-preserving training without moving sensitive data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address all the comments about removing these small icons/images
Signed-off-by: Meng Yan <[email protected]>
Hi @abhatt-rh , I shouldn’t perform the commit action through the web UI. Your suggested updates should now be applied. |
@yanmxa - tyvm for submitting this pr! Could you please provide a test plan that we can use to determine the desired outcome of the pattern? Nothing over the top, but definitely things that we can check either (preferably) through automation or visual checks in the UI ... Just as an example (doesn't have to be exactly the same) example test plan |
Fix issue: https://issues.redhat.com/browse/ACM-21006