Use ActiveSupport::Deprecator's API #113
Conversation
I will remove the relevant Gemfile files when I see green.
| else | ||
| warn(msg) | ||
| end | ||
| end | ||
|
|
||
| def self.deprecator |
There was a problem hiding this comment.
It's hilarious that they've deprecated their deprecator.
Is there any way we can support both the new and old styles together and keep old Rails support going? I'm ok to drop old versions if it becomes really onerous, but I wonder if there's a simple fix that keeps everything working.
I think this is the commit where things changed...
rails/rails@c682bf2
There was a problem hiding this comment.
yes, we can work around the Rails API detail with conditions.
But, the harder problem was that setup-ruby failed to install gems on a more basic level, when the bundler: 1 was configured.
There was a problem hiding this comment.
I don't have the time I wish I had to troubleshoot CI.
I'm ok to drop the old CI matrix versions for now just to get this out. Would you be able to add the compatibility conditional to make sure we still work on older Rails? Then I'll get this merged and out the door.
There was a problem hiding this comment.
😅 It may take some time, but we'll get there.
This PR fixes a wrong usage of Rails' Deprecator API.
In addition:
Gets to green.