Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Varnika|Yashna] Fix. IPv6 format is fixed #2083

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Varnika|Yashna] Fix. IPv6 format is fixed #2083

wants to merge 2 commits into from

Conversation

VarnikaB
Copy link

@VarnikaB VarnikaB commented Oct 20, 2022 •
edited
Loading

Fixed the invalid IPv6 address format:

  • BC:e4d5:c:e7b9::%40i0nccymtl9cwfKo.5vaeXLSGRMe:EDh2qs5wkhnPws5xQKqafjfAMm6wGFCJ.bVFsZfb
  • 1dC:0DF8:62D:3AC::%KTatXocjaFVioS0RTNQl4mA.V151o0RSy.JIu-D-D8.d3171ZWsSJ7PK4YjkJCRN0F
    as invalid

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

"fixes #2039"

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (531dc7f) to head (36b555c).
Report is 75 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2083   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WikiRik
WikiRik requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new IP addresses that are invalid to the tests

@rubiin rubiin added needs-tests 🧹 needs-update For PRs that need to be updated before landing labels Oct 22, 2022
@VarnikaB
Copy link
Author

I have added the test cases

@VarnikaB VarnikaB requested a review from WikiRik October 24, 2022 02:53
@VarnikaB
Copy link
Author

I have added the test cases could you please approve it soon.

@pano9000 pano9000 mentioned this pull request Dec 8, 2022
Open
@rubiin rubiin added 🧹 needs-update For PRs that need to be updated before landing ✅ LGTM and removed 🧹 needs-update For PRs that need to be updated before landing labels Mar 28, 2024
@profnandaa
Copy link
Member

Can fix the merge conflict, other than that, LGTM. Thanks for your contrib!

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 25, 2024
@ShreySinha02 ShreySinha02 mentioned this pull request Sep 14, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin approved these changes

@WikiRik WikiRik Awaiting requested review from WikiRik

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
✅ LGTM mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPv6 regex accepts invalid formats
5 participants
@VarnikaB @profnandaa @rubiin @WikiRik @pano9000