-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isSIP): check if string is a SIP #2458
Open
aabdullaharif
wants to merge
3
commits into
validatorjs:master
Choose a base branch
from
aabdullaharif:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
import assertString from './util/assertString'; | ||
|
||
/* Regular expression to match the SIP URI structure */ | ||
function isValidSipUri(uri) { | ||
const sipUriRegex = /^sips?:([^:@]+(:[^@]*)?@)?((([a-zA-Z0-9]([a-zA-Z0-9\-]*[a-zA-Z0-9])?\.)+[a-zA-Z]{2,}|(\d{1,3}\.){3}\d{1,3}|\[[0-9a-fA-F:]+\])(:\d{1,5})?)(;([a-zA-Z0-9-]+=[^;?]+|lr))*?(\?[^#]*)?$/; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we have a reference for this Regex? Are there sources for this? |
||
return sipUriRegex.test(uri); | ||
} | ||
|
||
function isValidPort(domain) { | ||
const portMatch = domain.match(/:(\d+)($|;)/); | ||
if (portMatch) { | ||
const port = parseInt(portMatch[1], 10); | ||
return !isNaN(port) && port > 0 && port <= 65535; | ||
} | ||
return true; | ||
} | ||
|
||
function isValidParameters(uri) { | ||
if (uri.includes(';')) { | ||
const params = uri.split(';').slice(1); | ||
for (const param of params) { | ||
/* | ||
- key is a valid parameter | ||
- key=value is a valid parameter | ||
- key=value1;key=value2;... is a valid parameter | ||
*/ | ||
const paramPart = param.split('?')[0]; | ||
if (!/^[a-zA-Z0-9-]+(=[a-zA-Z0-9_.!~*'();&=+$,%-]*)?$/.test(paramPart)) { | ||
return false; | ||
} | ||
} | ||
} | ||
return true; | ||
} | ||
|
||
|
||
/** | ||
* Function to validate if a string is a valid SIP URI | ||
* @param {String} str - The SIP URI string | ||
* @returns {Boolean} - Returns true if valid, otherwise false | ||
*/ | ||
export default function isSIP(str) { | ||
assertString(str); | ||
|
||
// First check the structure using regex | ||
if (!isValidSipUri(str)) { | ||
return false; | ||
} | ||
|
||
// Split the URI into parts (scheme, user, domain) | ||
const parts = str.split('@'); | ||
const domain = parts.pop(); | ||
|
||
// Check if there's a port | ||
if (!isValidPort(domain)) { | ||
return false; | ||
} | ||
|
||
// Validate parameters if present | ||
if (!isValidParameters(str)) { | ||
return false; | ||
} | ||
|
||
return true; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import test from '../testFunctions'; | ||
|
||
describe('isSIP', () => { | ||
it('should validate SIP URIs', () => { | ||
test({ | ||
validator: 'isSIP', | ||
valid: [ | ||
'sip:[email protected]', | ||
'sips:[email protected]', | ||
'sip:[email protected]:5060', | ||
'sip:[email protected];transport=tcp', | ||
'sips:[email protected]:5060', | ||
'sips:[email protected];transport=tcp', | ||
'sip:[email protected]', | ||
'sip:[email protected]', | ||
'sip:alice:[email protected]', | ||
'sip:[email protected]', | ||
'sips:[email protected]:5061;transport=tls', | ||
'sip:[email protected];user=phone', | ||
'sip:[email protected];method=INVITE', | ||
'sip:[email protected]?subject=test', | ||
'sip:[email protected];tag=1234', | ||
'sips:[email protected];secure=true', | ||
'sip:[email protected]:5060;lr', | ||
'sip:username:[email protected]:5060;transport=udp?header=value', | ||
], | ||
invalid: [ | ||
'https://www.example.com', | ||
'sip:user', | ||
'sips:@invalid.com', | ||
'sip:[email protected]', | ||
'sip:[email protected]:abc', | ||
'sip:[email protected];user=phone;tag=', | ||
'sips:user@domain:[email protected]', | ||
'sip:@', | ||
'sip:[email protected]', | ||
'sip:[email protected]', | ||
'sips:[email protected]:port', | ||
], | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put this in the correct alphabetical place (after
isSemVer
)