Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isEmail): reject quoted emails with blacklisted characters #2469

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alokdwivedi103
Copy link

@alokdwivedi103 alokdwivedi103 commented Oct 6, 2024

Fix (email-validation): reject quoted emails with blacklisted characters

Pointed out in issue 2392 - isEmail does not reject emails when blacklisted_chars includes quote.
To resolve this issue, the email validation function should be updated to properly enforce the blacklisting of quotes in the user part of the email. This can be achieved by:

  • Modifying the validation logic to check for blacklisted characters specifically in the user part of the email before further
    processing.
  • Implementing unit tests to cover various scenarios, including those provided above, to ensure that quotes are effectively
    excluded from valid email addresses.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@alokdwivedi103
Copy link
Author

alokdwivedi103 commented Oct 6, 2024

Let’s banish those quote villains from our emails! 🚫💬 Your feedback is gold! 💰

@rubiin
Copy link
Member

rubiin commented Oct 6, 2024

@alokdwivedi103 Add tests too

@alokdwivedi103
Copy link
Author

Added tests @rubiin

@rubiin rubiin changed the title fix(email-validation): reject quoted emails with blacklisted characters fix(isEmail): reject quoted emails with blacklisted characters Oct 6, 2024
@alokdwivedi103
Copy link
Author

@rubiin can you please help me close this pr as it is being pending for 2 weeks
Thanks..

@WikiRik
Copy link
Member

WikiRik commented Oct 20, 2024

We've merged #2414 in the past. Why do we need this additional one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants