Move auth check to the front #1475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requirepass is enabled, we want command calls to return NOAUTH instead of ERR with the error message. Otherwise this reveals that we have disabled the configuration in the server side. Signed-off-by: Binbin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1475 +/- ##
============================================
+ Coverage 70.86% 70.94% +0.08%
============================================
Files 119 120 +1
Lines 64852 65004 +152
============================================
+ Hits 45958 46120 +162
+ Misses 18894 18884 -10
|
madolson
reviewed
Dec 24, 2024
Signed-off-by: Binbin <[email protected]>
enjoy-binbin
changed the title
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
PingXie
added
the
release-notes
PingXie
approved these changes
Jan 6, 2025
zuiderkwast
approved these changes
Jan 6, 2025
I don't think it's a breaking change since it is moving from error -> error case. I would just list it as a release. I'm also OK with the change atm, but it looks like there are still some tests that need to get fixed. |
Signed-off-by: Binbin <[email protected]>
zuiderkwast
added
the
run-extra-tests
|
Maybe we should leave this until 9.0 though, just so that we have the safer boundary of the major version to claim we are making a behavior change. I agree that it makes sense to raise the security bar, but I don't think it's all that important if it's in 8.1 or 9.0. |
|
ok, let move it to 9.0 |
madolson
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requirepass is enabled, we want command calls to return NOAUTH
instead of ERR with the error message.
Previously, these checks were all before the auth check:
This may expose information such as whether the server supports the
command, whether the configuration item is enabled, etc. This is more
of a consistency issue as the same error message is returned when
requirepass is enabled, not a security issue.
This is a behavior change, though perhaps not a breaking one.