-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add availability_zone
to the HELLO command history
#1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good followup. We should find a way to add some type of failure on the history, since I know we miss this periodically.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1524 +/- ##
============================================
- Coverage 70.85% 70.85% -0.01%
============================================
Files 120 120
Lines 64917 64956 +39
============================================
+ Hits 46000 46024 +24
- Misses 18917 18932 +15
|
@rueian You also need to run |
Signed-off-by: Rueian <[email protected]>
Oh, thanks for reminding me about that! I have updated the commands.def file. |
config name should be availability-zone Signed-off-by: Binbin <[email protected]>
Thank you @enjoy-binbin for the correction! |
This PR is for #1487.