Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability_zone to the HELLO command history #1524

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

rueian
Copy link
Contributor

@rueian rueian commented Jan 7, 2025

This PR is for #1487.

Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good followup. We should find a way to add some type of failure on the history, since I know we miss this periodically.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (3b52186) to head (62e04cb).
Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1524      +/-   ##
============================================
- Coverage     70.85%   70.85%   -0.01%     
============================================
  Files           120      120              
  Lines         64917    64956      +39     
============================================
+ Hits          46000    46024      +24     
- Misses        18917    18932      +15     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)

... and 48 files with indirect coverage changes

@madolson
Copy link
Member

madolson commented Jan 7, 2025

@rueian You also need to run make and update the commands.def file.

@rueian
Copy link
Contributor Author

rueian commented Jan 8, 2025

@rueian You also need to run make and update the commands.def file.

Oh, thanks for reminding me about that! I have updated the commands.def file.

src/commands.def Outdated Show resolved Hide resolved
src/commands/hello.json Outdated Show resolved Hide resolved
config name should be availability-zone

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin merged commit dc4628d into valkey-io:unstable Jan 8, 2025
48 checks passed
@rueian
Copy link
Contributor Author

rueian commented Jan 8, 2025

Thank you @enjoy-binbin for the correction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants