fix: assign positioning options per element (#5668) #5706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5668
save positioning options per element to prevent overrides
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.
Hi! I opened #5668 a couple of weeks ago, and this is my attempt at fixing it.
I noticed the options related to adaptive positioning were saved in a single property in the positioning service here . As a result, every time there were two components open, those options were overridden by the last one. So, my idea was to save the options separately for each component.
Any suggestions are welcome (should I add tests or demos?).