Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cocoapods to 1.11.3 #3360

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

jeanregisser
Copy link
Member

Description

Initially started this to fix RET-568, but it will only be fixed with CocoaPods 1.12 which hasn't been released yet. So we'll have to wait. In the meantime we'll still benefit from updating, 1.10 is pretty old.

Test plan

  • CI tests pass

Related issues

Backwards compatibility

Yes

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #3360 (6caf392) into main (30e0291) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
+ Coverage   81.29%   81.31%   +0.01%     
==========================================
  Files         641      641              
  Lines       22362    22362              
  Branches     4032     4032              
==========================================
+ Hits        18180    18184       +4     
+ Misses       4121     4117       -4     
  Partials       61       61              
Impacted Files Coverage Δ
src/tokens/utils.ts 100.00% <0.00%> (+2.94%) ⬆️
src/web3/saga.ts 80.80% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e0291...6caf392. Read the comment docs.

Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still works on my machine ✨ 🚀

@jeanregisser jeanregisser merged commit 1d437b0 into main Jan 17, 2023
@jeanregisser jeanregisser deleted the jeanregisser/update-cocoapods branch January 17, 2023 11:03
@valora-inc valora-inc deleted a comment from linear bot Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants