Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): move more remote config to Statsig #6474

Merged
merged 27 commits into from
Feb 5, 2025

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Feb 3, 2025

Description

This PR moves the following remote config variables to statsig dynamic config:

  • dapp list url -> app config
  • dapp in-app webview enabled -> dapps webview config
  • celo news -> app config
  • swap price impact warning threshold -> swap config
  • maxNumRecentDapps is no longer used and just removed here

Test plan

n/a

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@kathaypacific kathaypacific changed the title Kathy/remote config statsig 2 chore(config): move more remote config to Statsig Feb 3, 2025
Base automatically changed from kathy/remote-config-statsig to main February 5, 2025 09:05
@kathaypacific kathaypacific marked this pull request as ready for review February 5, 2025 09:18
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (60519ee) to head (5ec4712).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6474      +/-   ##
==========================================
+ Coverage   89.02%   89.04%   +0.02%     
==========================================
  Files         729      729              
  Lines       31871    31858      -13     
  Branches     5819     6138     +319     
==========================================
- Hits        28373    28369       -4     
+ Misses       3450     3441       -9     
  Partials       48       48              
Files with missing lines Coverage Δ
src/app/reducers.ts 26.82% <ø> (ø)
src/app/saga.ts 70.61% <ø> (ø)
src/app/selectors.ts 96.42% <ø> (-0.13%) ⬇️
src/celoNews/CeloNewsFeed.tsx 97.22% <100.00%> (+0.07%) ⬆️
src/dapps/saga.ts 83.87% <100.00%> (+0.82%) ⬆️
src/dapps/selectors.ts 100.00% <100.00%> (ø)
src/dapps/slice.ts 23.52% <100.00%> (-2.67%) ⬇️
src/firebase/firebase.ts 41.66% <ø> (+0.64%) ⬆️
src/firebase/remoteConfigValuesDefaults.ts 100.00% <ø> (ø)
src/redux/migrations.ts 97.03% <100.00%> (+<0.01%) ⬆️
... and 7 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60519ee...5ec4712. Read the comment docs.

Copy link
Contributor

@sviderock sviderock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kathaypacific kathaypacific added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 7487b89 Feb 5, 2025
16 checks passed
@kathaypacific kathaypacific deleted the kathy/remote-config-statsig-2 branch February 5, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants