Skip to content

refactor: majority of mechs logic go into OlasMech #218

refactor: majority of mechs logic go into OlasMech

refactor: majority of mechs logic go into OlasMech #218

Triggered via pull request December 16, 2024 19:02
@kupermindkupermind
synchronize #53
refactor
Status Failure
Total duration 47s
Artifacts

workflow.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 14 warnings
build
Process completed with exit code 1.
gitleaks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
build: contracts/Karma.sol#L71
Avoid to use inline assembly. It is acceptable only in rare cases
build: contracts/Karma.sol#L155
Avoid to use inline assembly. It is acceptable only in rare cases
build: contracts/KarmaProxy.sol#L46
Avoid to use inline assembly. It is acceptable only in rare cases
build: contracts/KarmaProxy.sol#L50
Avoid to use low level calls
build: contracts/KarmaProxy.sol#L57
Contract [KarmaProxy] Fallback should be payable and external (code a receive() function is recommended!)
build: contracts/KarmaProxy.sol#L58
Avoid to use inline assembly. It is acceptable only in rare cases
build: contracts/MechFactoryFixedPrice.sol#L27
Provide an error message for revert
build: contracts/MechFactoryFixedPrice.sol#L27
GC: Use Custom Errors instead of revert statements
build: contracts/MechMarketplace.sol#L51
Contract has 16 states declarations but allowed no more than 15
build: contracts/MechMarketplace.sol#L77
Immutable variables name are set to be in capitalized SNAKE_CASE
build: scripts/deployment/verify_00_agent_mech.js#L1
'ethers' is assigned a value but never used
build: test/AgentMech.js#L17
'agentHash' is assigned a value but never used