Mech fixed testing #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Dec 17, 2024
kupermind
commented
- Converge with refactoring and updating tests.
kupermind
commented
Dec 17, 2024
| constructor( | ||
| address _serviceRegistry, | ||
| address _stakingFactory, | ||
| address _karma, | ||
| address _wrappedNativeToken, | ||
| address _buyBackBurner, |
There was a problem hiding this comment.
Proxy-storage params can't go into constructor
kupermind
commented
Dec 17, 2024
| @@ -622,7 +616,7 @@ contract MechMarketplace is IErrorsMarketplace { | |||
| getDomainSeparator(), | |||
| keccak256( | |||
| abi.encode( | |||
| block.timestamp, | |||
There was a problem hiding this comment.
No need for block.timestamp at the end, just complicates things retrieval. We already have nonces and the address of a current marketplace address.
DavidMinarsch
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.