(govern): change formatting to local time #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
requested review from
mohandast52,
oaksprout and
truemiller
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
Tanya-atatakai
commented
Oct 18, 2024
| @@ -62,7 +62,7 @@ export const VotingPercentComponent = ({ | |||
| isLoading={isLoading} | |||
| title="% of total voting power" | |||
| value={ | |||
| Number(votingPower) === 0 || Number(totalSupply) === 0 | |||
| votingPower === undefined || Number(votingPower) === 0 || Number(totalSupply) === 0 | |||
There was a problem hiding this comment.
just noticed we display null% for users with no veOLAS, quickly fixed
|
Gitleaks is fixed here #117 |
oaksprout
approved these changes
Oct 18, 2024
DavidMinarsch
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change time formatting from UTC to local (the updated function is also used on donate and veOLAS pages)
Fixes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply