Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitleaks #15

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix gitleaks #15

merged 2 commits into from
Mar 19, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai commented Mar 19, 2024

Proposed changes

Gitleaks is currently fails with exit code 1, need to solve it

Fixes

  • updates gitleaks package version
  • removes --exit-code 0 so job is not completed with a false success
  • provides -b (--baseline-path) flag to each app's config that points to the created report so job only fails if new issues appear
image

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Mar 19, 2024

Someone is attempting to deploy this pull request to the autonolas Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@Tanya-atatakai Tanya-atatakai changed the base branch from mohan/registry-test-cases to main March 19, 2024 12:44
@Tanya-atatakai Tanya-atatakai force-pushed the fix/gitleaks-ignore branch 2 times, most recently from 2fe9dcf to 4803963 Compare March 19, 2024 14:50
@Tanya-atatakai Tanya-atatakai changed the base branch from main to mohan/registry-test-cases March 19, 2024 14:50
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
autonolas-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:06pm
tokenomics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:06pm

Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks @Tanya-atatakai

@mohandast52 mohandast52 merged commit e87f009 into mohan/registry-test-cases Mar 19, 2024
4 of 6 checks passed
@mohandast52 mohandast52 deleted the fix/gitleaks-ignore branch March 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants