Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git workflow #17

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Fix git workflow #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bedff35
Fix git workflow
Tanya-atatakai Mar 20, 2024
e748466
Trigger git workflow
Tanya-atatakai Mar 20, 2024
ad0387e
trigger
mohandast52 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/autonolas-registry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
paths:
- 'apps/autonolas-registry/**'
pull_request:
branches:
- main
paths:
- 'apps/autonolas-registry/**'

Expand All @@ -22,7 +24,6 @@ jobs:
node-version: 18
- name: Install modules
run: yarn
- run: git branch --track main origin/main
- name: Run ESLint
run: yarn nx lint autonolas-registry
- name: Run Test
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/tokenomics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ on:
paths:
- 'apps/tokenomics/**'
pull_request:
branches:
- main
paths:
- 'apps/tokenomics/**'

Expand All @@ -24,7 +26,6 @@ jobs:
node-version: 18
- name: Install modules
run: yarn
- run: git branch --track main origin/main
- name: Run ESLint
run: yarn nx lint tokenomics
- name: Run Test
Expand Down
1 change: 0 additions & 1 deletion apps/autonolas-registry/components/ListComponents/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import { Tabs } from 'antd';
import { useRouter } from 'next/router';
import { notifyError } from '@autonolas/frontend-library';

import { NAV_TYPES } from 'util/constants';
import ListTable from 'common-util/List/ListTable';
import {
Expand Down Expand Up @@ -116,7 +115,7 @@
}
}
})();
}, [account, chainId, isL1OnlyNetwork, total, currentPage, isSvm]);

Check warning on line 118 in apps/autonolas-registry/components/ListComponents/index.jsx

View workflow job for this annotation

GitHub Actions / build 

React Hook useEffect has missing dependencies: 'currentTab', 'list.length', and 'searchValue'. Either include them or remove the dependency array

/**
* Search (All components, My Components)
Expand Down
1 change: 1 addition & 0 deletions apps/autonolas-registry/tests/common-util/YellowButton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import '@testing-library/jest-dom';
import { render } from '@testing-library/react';

import { YellowButton } from '../../common-util/YellowButton';

describe('YellowButton', () => {
Expand Down
1 change: 0 additions & 1 deletion apps/tokenomics/components/Home/Bonding/BondingList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import { COLOR, NA } from '@autonolas/frontend-library';
import { QuestionCircleOutlined } from '@ant-design/icons';
import styled from 'styled-components';

import { BONDING_PRODUCTS } from 'util/constants';
import { notifySpecificError, parseToEth } from 'common-util/functions';
import { useHelpers } from 'common-util/hooks/useHelpers';
Expand Down Expand Up @@ -222,7 +221,7 @@
// fetch the bonding list
useEffect(() => {
getProducts();
}, [account, chainId, bondingProgramType]);

Check warning on line 224 in apps/tokenomics/components/Home/Bonding/BondingList.jsx

View workflow job for this annotation

GitHub Actions / build 

React Hook useEffect has a missing dependency: 'getProducts'. Either include it or remove the dependency array

const onBondClick = (row) => {
setProductDetails(row);
Expand Down
Loading