feat: [Registry] Better search #21
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,14 +1,13 @@ | ||||||
| import { useState, useCallback } from 'react'; | ||||||
| import PropTypes from 'prop-types'; | ||||||
| import capitalize from 'lodash/capitalize'; | ||||||
| import { Row, Col, Button, Typography } from 'antd'; | ||||||
| import { get } from 'lodash'; | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. Hmm, sure. Does it add any improvements? There was a problem hiding this comment. yeah, there's a small difference using this plugin: https://marketplace.visualstudio.com/items?itemName=ambar.bundle-size not 100% sure if it's accurate post-build, but if it is then we should consider reducing where we can |
||||||
| import { Loader, NA } from '@autonolas/frontend-library'; | ||||||
|
|
||||||
| import { NAV_TYPES } from '../../util/constants'; | ||||||
| import { useMetadata } from '../hooks/useMetadata'; | ||||||
| import { useHelpers } from '../hooks'; | ||||||
| import { typePropType } from '../propTypes'; | ||||||
| import { IpfsHashGenerationModal } from '../List/IpfsHashGenerationModal'; | ||||||
| import { useDetails } from './useDetails'; | ||||||
|
|
@@ -31,16 +30,16 @@ export const Details = ({ | |||||
| }) => { | ||||||
| const [isModalVisible, setIsModalVisible] = useState(false); | ||||||
|
|
||||||
| const { isMainnet } = useHelpers(); | ||||||
| const { isLoading, isOwner, info, ownerAddress, tokenUri, updateDetails } = | ||||||
| useDetails({ | ||||||
| id, | ||||||
| type, | ||||||
| getDetails, | ||||||
| getOwner, | ||||||
| getTokenUri, | ||||||
| }); | ||||||
| const { nftImageUrl, packageName } = useMetadata(tokenUri); | ||||||
|
|
||||||
| // Update button to be show only if the connected account is the owner | ||||||
| // and only for agent and component | ||||||
|
|
@@ -58,10 +57,18 @@ export const Details = ({ | |||||
| <> | ||||||
| <Header> | ||||||
| <div> | ||||||
| {isMainnet ? ( | ||||||
| <> | ||||||
mohandast52 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| <DetailsTitle level={3}>{packageName}</DetailsTitle> | ||||||
| </> | ||||||
| ) : ( | ||||||
| <> | ||||||
| <Text strong>{`${capitalize(type)} Name`}</Text> | ||||||
| <DetailsTitle level={2}> | ||||||
| {`${capitalize(type)} ID ${id}`} | ||||||
| </DetailsTitle> | ||||||
| </> | ||||||
| )} | ||||||
| </div> | ||||||
|
|
||||||
| <div className="right-content"> | ||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a component with a single export, please move to components folder and name Details.jsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently used by agents, components, and services, so I've kept it in the
common-utils. Any reason to move it tocomponentsfolder instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, so...
the
componentsfolder is for reusable components i.e. this Details component, used by multiple othersthe
pagesfolder should be reserved for specific pages that pull in reusable components to create the expected pagethe
common-utilsorutilsfolders should be for helper functions, i.e. string parsers, converters, object manipulation .etc, perhaps constants, though I tend to put it outside ofutilsfolder to seperate concernsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your point, but my approach differs slightly:
pagesimply imports the core components. I believe if we start adding the core components here, it will become too large to maintain, especially since they tend to grow in size.componentsis for core components such as Agents, Services, etc.common-utilis intended for common components that can be used by other core components. For example components that can be used in Agents, Services, etcutilsis reserved for constants, but we could potentially move it tocommon-util.I think eventually, the truly reusable components will be moved to feature libraries in NX, such as the login component, utility functions, etc.