Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(govern) fix: changes for next week start, veOlas -> veOLAS #72

Merged
merged 2 commits into from
Jul 30, 2024
Merged

(govern) fix: changes for next week start, veOlas -> veOLAS #72

merged 2 commits into from
Jul 30, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai commented Jul 30, 2024 •
edited
Loading

Fixes

  1. Fixed the way we calculated the "start of next week", we thought it's always Monday but it's Thursday (by Unix time)
  2. Provided better explanation of what the start of next week is
  3. The Rollover pool is always sorted to the end
  4. Renamed veOlas -> veOLAS

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bond ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:34pm
govern 🛑 Canceled (Inspect) Jul 30, 2024 5:34pm
launch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:34pm
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:34pm
tokenomics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:34pm

@Tanya-atatakai Tanya-atatakai requested a review from kupermind July 30, 2024 16:46
mohandast52
mohandast52 reviewed Jul 30, 2024
View reviewed changes
apps/govern/components/Contracts/EditVotes/validations.tsx Outdated Show resolved Hide resolved
apps/govern/components/Contracts/ContractsList.tsx Outdated Show resolved Hide resolved
apps/govern/hooks/useFetchStakingContractsList.ts Outdated Show resolved Hide resolved
apps/govern/hooks/useFetchStakingContractsList.ts Outdated Show resolved Hide resolved
apps/govern/common-util/functions/time.ts Outdated Show resolved Hide resolved
@DavidMinarsch DavidMinarsch merged commit 23eb9e9 into main Jul 30, 2024
8 checks passed
@DavidMinarsch DavidMinarsch deleted the tanya/govern-fixes branch July 30, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kupermind kupermind kupermind approved these changes

@mohandast52 mohandast52 mohandast52 approved these changes

@DavidMinarsch DavidMinarsch DavidMinarsch approved these changes

@oaksprout oaksprout Awaiting requested review from oaksprout oaksprout is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tanya-atatakai @DavidMinarsch @mohandast52 @kupermind