Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bond & tokenomics) feat: bond migration final #75

Merged
merged 22 commits into from
Aug 23, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Aug 8, 2024

Proposed changes

Bond app

  • Bonding products
2
  • Bond
bond.mp4
  • Manage Solana liquidity
1 333
  • Bonds created
bonds

Tokenomics app

  • Epoch status and app's menu
epoch
  • Deposit
deposit.mov
  • Developer rewards
check-rewards estimate rewards

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 added the enhancement New feature or request label Aug 8, 2024
@mohandast52 mohandast52 self-assigned this Aug 8, 2024
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bond ✅ Ready (Inspect) Visit Preview 1 resolved Aug 22, 2024 2:07pm
govern 🛑 Canceled (Inspect) Aug 22, 2024 2:07pm
launch 🛑 Canceled (Inspect) Aug 22, 2024 2:07pm
registry 🛑 Canceled (Inspect) Aug 22, 2024 2:07pm
tokenomics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 2:07pm

</a>
),
render: (x, details) => {
if (isCurrentPriceLpZero(x)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the price is 0 then it will not stop loading
would nullish check be better for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value is set to 0, hence this should be fine.

@mohandast52 mohandast52 merged commit dcc2ad3 into main Aug 23, 2024
5 of 8 checks passed
@mohandast52 mohandast52 deleted the mohan/bond-migration branch August 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants