(govern) feat: migrate donate to govern #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tanya-atatakai
force-pushed
the
tanya/govern-donate
branch
from
b090361 to
3d02ea9
Compare
Tanya-atatakai
force-pushed
the
tanya/govern-donate
branch
from
a3e7656 to
0bf812e
Compare
truemiller
reviewed
Aug 27, 2024
truemiller
approved these changes
Aug 27, 2024
mohandast52
reviewed
Aug 27, 2024
| @@ -46,3 +51,17 @@ export const getVeOlasContract = () => { | |||
| const contract = getContract(abi, address); | |||
| return contract; | |||
| }; | |||
|
|
|||
| export const getTokenomicsContract = () => { | |||
| const abi = TOKENOMICS.abi as unknown as AbiItem[]; | |||
There was a problem hiding this comment.
can we add "AbiItem[]" directly in TOKENOMICS?
There was a problem hiding this comment.
actually not that easy, there are difficulties with providing the correct type for abi. I just realised that if I don't specify the type (I did it for some contracts as Abi from viem, see libs/util-contracts/src/lib/abiAndAddresses/types.ts), wagmi hooks recognise returned values correctly, e.g. as number or bigint, or string, etc. Ideally would be good to allocate some time to resolve this properly
mohandast52
approved these changes
Aug 27, 2024
DavidMinarsch
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Migrate Donate page from tokenomics to govern app
Donate
Screen.Recording.2024-08-27.at.13.09.15.mov
Epoch start
Screen.Recording.2024-08-27.at.13.08.49.mov
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply