(operate) feat: Add column for how much xdai needed in staking contracts page #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mohandast52
changed the title
mohandast52
requested review from
oaksprout,
Tanya-atatakai and
truemiller
as code owners
truemiller
approved these changes
Sep 3, 2024
|
Just be mindful of CoinGecko rate limits as this list grows longer, can probably cache some requests if it becomes a problem, or reuse values CoinGecko free plan request limits are pretty stingy |
|
@truemiller Agreed, I thought of caching as well. Since there's only one per page, it should be fine IMO, but I'll work on finding a better solution. |
Tanya-atatakai
approved these changes
Sep 3, 2024
oaksprout
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply