refactor and test: addressing internal audit and adding full coverage #519
Annotations
22 warnings
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v3, codecov/codecov-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Run solhint:
contracts/DeploymentFactory.sol#L4
global import of path @openzeppelin/contracts/utils/Create2.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run solhint:
contracts/DeploymentFactory.sol#L5
global import of path ./OLAS.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run solhint:
contracts/DeploymentFactory.sol#L6
global import of path ./veOLAS.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run solhint:
contracts/OLAS.sol#L4
global import of path ../lib/solmate/src/tokens/ERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run solhint:
contracts/OLAS.sol#L28
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
Run solhint:
contracts/Timelock.sol#L4
global import of path @openzeppelin/contracts/governance/TimelockController.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run solhint:
contracts/buOLAS.sol#L2
Found more than One contract per file. 2 contracts found!
|
|
Run solhint:
contracts/buOLAS.sol#L4
global import of path @openzeppelin/contracts/token/ERC20/IERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run solhint:
contracts/buOLAS.sol#L5
global import of path @openzeppelin/contracts/utils/introspection/IERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run solhint:
contracts/buOLAS.sol#L6
global import of path ./interfaces/IErrors.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Run ESLint:
scripts/deployment/bridges/optimistic/test/deploy_00_mock_timelock.js#L14
'gasPriceInGwei' is assigned a value but never used
|
|
Run ESLint:
scripts/deployment/bridges/polygon/test/fx_goerli_mumbai_hello_world.js#L35
'fxChild' is assigned a value but never used
|
|
Run ESLint:
scripts/deployment/bridges/polygon/test/fx_mumbai_goerli_token_transfer.js#L27
'fxRoot' is assigned a value but never used
|
|
Run ESLint:
scripts/deployment/bridges/polygon/test/fx_mumbai_goerli_token_transfer.js#L35
'fxChild' is assigned a value but never used
|
|
Run ESLint:
scripts/deployment/bridges/polygon/test/fx_mumbai_goerli_token_transfer.js#L51
'bridgedERC20' is assigned a value but never used
|
|
Run ESLint:
scripts/deployment/bridges/wormhole/test/deploy_00_mock_timelock.js#L14
'gasPriceInGwei' is assigned a value but never used
|
|
Run ESLint:
scripts/proposals/proposal_01_goerli_sync_mainnet.js#L12
'provider' is assigned a value but never used
|
|
Run ESLint:
scripts/proposals/proposal_04_CM_guard.js#L11
'timelockAddress' is assigned a value but never used
|
|
Run ESLint:
scripts/proposals/proposal_04_CM_guard.js#L23
'CMAddress' is assigned a value but never used
|
|
Run ESLint:
scripts/proposals/proposal_04_CM_guard_goerli.js#L11
'timelockAddress' is assigned a value but never used
|
Loading