feat and chore: Optimism L1 to L2 message passing and deployment scripts #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Feb 21, 2024
kupermind
commented
- Optimism L1 to L2 message passing and deployment scripts.
kupermind
commented
Feb 23, 2024
Comment on lines
-24
to
+20
| function execute(bytes memory payload) external { | ||
| (bool success, ) = fxRoot.call(payload); | ||
| function execute(bytes memory payload) external payable { | ||
| (bool success, ) = fxRoot.call{value: msg.value}(payload); |
There was a problem hiding this comment.
Our real Timelock has a payable execute() function
kupermind
commented
Feb 23, 2024
Comment on lines
-80
to
+130
| apiURL: "https://blockscout.com/gnosis/chiado/api", | ||
| browserURL: "https://blockscout.com/gnosis/chiado", | ||
| apiURL: "https://gnosis-chiado.blockscout.com/api", | ||
| browserURL: "https://gnosis-chiado.blockscout.com/", |
There was a problem hiding this comment.
Changed to actual ones.
77ph
approved these changes
Feb 23, 2024
mariapiamo
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.