feat: wormhole bridging for governance #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Feb 26, 2024
kupermind
commented
- Wormhole bridging for governance.
kupermind
commented
Feb 27, 2024
Comment on lines
65
to
69
| uint16 public immutable sourceGovernorChainId; | ||
| // Source governor address on L1 that is authorized to propagate the transaction execution across the bridge | ||
| address public sourceGovernor; | ||
| // Mapping of delivery hashes | ||
| mapping(bytes32 => bool) public mapDeliveryHashes; |
There was a problem hiding this comment.
These are two major differences for the wormhole contract - we need to check the source chain Id, and the delivery hash such that it does not repeat.
kupermind
commented
Feb 27, 2024
Comment on lines
+24
to
+25
| "@nomicfoundation/hardhat-network-helpers": "^1.0.9", | ||
| "@nomicfoundation/hardhat-toolbox": "^2.0.2", |
There was a problem hiding this comment.
Updating hardhat packages such that the default EVM is Paris, and we don't have issues with the deployment on networks that don't deal with PUSH0 yet.
77ph
previously approved these changes
Feb 27, 2024
mariapiamo
reviewed
Feb 29, 2024
| @@ -0,0 +1 @@ | |||
| {"contractVerification":true,"useLedger":false,"derivationPath":"m/44'/60'/2'/0/0","providerName":"celoAlfajores","gasPriceInGwei":"10","networkURL":"https://alfajores-forno.celo-testnet.org","sourceGovernorChainId":"10002","L1WormholeRelayerAddress":"0x7B1bD7a6b4E61c2a123AC6BC2cbfC614437D0470","timelockAddress":"0x14CF2e543AB75B321bcf84C3AcC88d570Ccf9106","L2WormholeRelayerAddress":"0x306B68267Deb7c5DfCDa3619E22E9Ca39C374f84","wormholeMessengerAddress":"0x945550dECe7E40ae70C6ebf5699637927eAF13E9","childMockERC20Address":"0x34235f9D447f9F54167e2Ac7A0F4283cB3fAD669"} | |||
There was a problem hiding this comment.
'sourceGovernorChainId' is the source governor wormhole format chain Id.
The source chain should be Ethereum, no?
There was a problem hiding this comment.
yes, "sourceGovernorChainId":"10002" - sepolia
and "celo" here is testnet celo ref: alfajores-forno.celo-testnet.org
so, globals for testnet to testnet
mariapiamo
previously approved these changes
Feb 29, 2024
refactor and test: bridging contracts
doc: internal audit based on Optimism and Wormhole contracts
mariapiamo
approved these changes
Feb 29, 2024
77ph
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.