refactor and test: addressing internal audit and adding full coverage #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Mar 6, 2024
kupermind
commented
- Addressing internal audit with small refactoring;
- Adding full test coverage.
kupermind
commented
Mar 6, 2024
Comment on lines
+381
to
+382
| if (verifierL2s[i].code.length == 0) { | ||
| revert ContractOnly(verifierL2s[i]); |
There was a problem hiding this comment.
Checking that the L2 verifier is a contract
kupermind
commented
Mar 6, 2024
Comment on lines
+28
to
+29
| bytes4 targetSelector = bytes4(data); | ||
| targetSelectorChainId |= uint256(uint32(targetSelector)) << 160; |
There was a problem hiding this comment.
Small code optimization
kupermind
commented
Mar 6, 2024
Comment on lines
-27
to
+22
| bytes4 public constant CREATE_TICKET_UNSAFE = bytes4(keccak256(bytes("unsafeCreateRetryableTicket(address,uint256,uint256,address,address,uint256,uint256,uint256,bytes)"))); | ||
| bytes4 public constant CREATE_TICKET_UNSAFE = bytes4(keccak256(bytes("unsafeCreateRetryableTicket(address,uint256,uint256,address,address,uint256,uint256,bytes)"))); |
There was a problem hiding this comment.
Bugs here and there ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.