feat: vote weighting initial contract #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Mar 12, 2024
kupermind
commented
- Vote Weighting initial contract.
test: vote weighting initial testing
L1 -> L2 -> L1
mariapiamo
reviewed
Apr 16, 2024
contracts/VoteWeighting.sol
Outdated
| /// @param nominee Address of the nominee. | ||
| /// @param chainId Chain Id. | ||
| /// @param weight New nominee weight. | ||
| function changeNomineeWeight(address nominee, uint256 chainId, uint256 weight) external { |
|
|
||
| /// @dev Get Nominee relative weight (not more than 1.0) normalized to 1e18. | ||
| /// (e.g. 1.0 == 1e18). Inflation which will be received by it is | ||
| /// inflation_rate * relativeWeight / 1e18. |
There was a problem hiding this comment.
In the original specs, if inflation_rate > votes_for_Nominee -> votes_for_Nominee * relativeWeight / 1e18. Dispenser takes care of this?
There was a problem hiding this comment.
we will do it, using totalSum from this menthod
| return _nomineeRelativeWeight(nominee, chainId, time); | ||
| } | ||
|
|
||
| /// @dev Allocate voting power for changing pool weights. |
There was a problem hiding this comment.
Suggested change
| /// @dev Allocate voting power for changing pool weights. | |
| /// @dev Allocate voting power for changing Nominee weights. |
77ph
previously approved these changes
Apr 16, 2024
refactor: accounting for non-evm chains for vote weighting
feat: couple of view methods to get nominees info
Vote weighting fuzzing
mariapiamo
approved these changes
May 13, 2024
77ph
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.