Create proposal for guardCM and CM setTargetSelectors on guardCM and revoke CM's canceller role #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariapiamo
changed the title
kupermind
reviewed
Sep 18, 2023
| const values = new Array(2).fill(0); | ||
| const callDatas = [ | ||
| // CM is always able to schedule pause() and disableToken(token) function calls via the timelock | ||
| // When the new owner address are known, add the CM.swapOwner method |
There was a problem hiding this comment.
Not sure about this one. The CM itself can't perform actions on itself after setting a guard. The timelock is able to change / swap owners via the governance vote.
kupermind
reviewed
Sep 18, 2023
| const callDatas = [ | ||
| // CM is always able to schedule pause() and disableToken(token) function calls via the timelock | ||
| // When the new owner address are known, add the CM.swapOwner method | ||
| guardCM.interface.encodeFunctionData("setTargetSelectors", [[treasuryAddress, treasuryAddress],[0x3f4ba83a, 0x23e27a64], [true, true]]), |
There was a problem hiding this comment.
What about ServiceManager pause function?
kupermind
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create proposal