refactor and test and chore: audit reaction #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Nov 28, 2023
kupermind
commented
- Reaction to the audit;
- Added tests.
77ph
reviewed
Nov 28, 2023
| IERC20(childToken).transferFrom(msg.sender, address(this), amount); | ||
| bool success = IERC20(childToken).transferFrom(msg.sender, address(this), amount); | ||
| if (!success) { | ||
| revert TransferFailed(rootToken, msg.sender, address(this), amount); |
There was a problem hiding this comment.
revert TransferFailed(childToken, msg.sender, address(this), amount); ?
There was a problem hiding this comment.
Not moved transferFrom to end-of-function by CEI
mariapiamo
approved these changes
Nov 28, 2023
77ph
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.