Merge pull request #119 from valory-xyz/service_staking_tests

test: Initial testing for staking
valory-xyz · Oct 6, 2023 · efe9ab1 · efe9ab1
2 parents db5b1fc + 7977c7e
commit efe9ab1
Show file tree

Hide file tree

Showing 3 changed files with 586 additions and 5 deletions.
diff --git a/contracts/staking/ServiceStaking.sol b/contracts/staking/ServiceStaking.sol
@@ -29,6 +29,7 @@ contract ServiceStaking is ServiceStakingBase {
     /// @param amount Amount to withdraw.
     function _withdraw(address to, uint256 amount) internal override {
         // Update the contract balance
+        // TODO: Fuzz this such that the amount is never bigger than the balance
         balance -= amount;
 
         // Transfer the amount

diff --git a/contracts/staking/ServiceStakingBase.sol b/contracts/staking/ServiceStakingBase.sol
@@ -18,7 +18,7 @@ interface IService {
     /// @param id Service Id.
     function transferFrom(address from, address to, uint256 id) external;
 
-    /// @dev Gets the service instance from the map of services.
+    /// @dev Gets service parameters from the map of services.
     /// @param serviceId Service Id.
     /// @return securityDeposit Registration activation deposit.
     /// @return multisig Service multisig address.
@@ -123,6 +123,7 @@ abstract contract ServiceStakingBase is IErrorsRegistries {
             revert ZeroAddress();
         }
 
+        maxNumServices = _maxNumServices;
         rewardsPerSecond = _rewardsPerSecond;
         minStakingDeposit = _minStakingDeposit;
         livenessRatio = _livenessRatio;
@@ -276,20 +277,20 @@ abstract contract ServiceStakingBase is IErrorsRegistries {
             // If total allocated rewards are not enough, adjust the reward value
             if (totalRewards > lastAvailableRewards) {
                 // Traverse all the eligible services and adjust their rewards proportional to leftovers
-                totalRewards = 0;
+                uint256 updatedTotalRewards = 0;
                 for (uint256 i = 0; i < numServices; ++i) {
                     // Calculate the updated reward
                     uint256 updatedReward = (eligibleServiceRewards[i] * lastAvailableRewards) / totalRewards;
                     // Add to the total updated reward
-                    totalRewards += updatedReward;
+                    updatedTotalRewards += updatedReward;
                     // Add reward to the service overall reward
                     uint256 curServiceId = eligibleServiceIds[i];
                     mapServiceInfo[curServiceId].reward += updatedReward;
                 }
 
                 // If the reward adjustment happened to have small leftovers, add it to the last traversed service
-                if (lastAvailableRewards > totalRewards) {
-                    mapServiceInfo[numServices - 1].reward += lastAvailableRewards - totalRewards;
+                if (lastAvailableRewards > updatedTotalRewards) {
+                    mapServiceInfo[numServices - 1].reward += lastAvailableRewards - updatedTotalRewards;
                 }
                 // Set available rewards to zero
                 lastAvailableRewards = 0;
@@ -302,6 +303,7 @@ abstract contract ServiceStakingBase is IErrorsRegistries {
                 }
 
                 // Adjust available rewards
+                // TODO: Fuzz this such that totalRewards is never bigger than lastAvailableRewards
                 lastAvailableRewards -= totalRewards;
             }