New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.1.7 internal audit4.1 #121

Merged

kupermind merged 3 commits into main from v1.1.7-internal-audit4.1

Oct 6, 2023

+14,237 −0

Merged

V1.1.7 internal audit4.1 #121

doc: internal audit ref: v1.1.7. update README

Annotations

12 warnings

The following actions uses node12 which is deprecated and will be forced to run on node16: codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

contracts/AgentRegistry.sol#L4

global import of path ./UnitRegistry.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/AgentRegistry.sol#L5

global import of path ./interfaces/IRegistry.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/AgentRegistry.sol#L11

Immutable variables name are set to be in capitalized SNAKE_CASE

contracts/ComponentRegistry.sol#L4

global import of path ./UnitRegistry.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/GenericManager.sol#L4

global import of path ./interfaces/IErrorsRegistries.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/GenericRegistry.sol#L4

global import of path ../lib/solmate/src/tokens/ERC721.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/GenericRegistry.sol#L5

global import of path ./interfaces/IErrorsRegistries.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/RegistriesManager.sol#L4

global import of path ./GenericManager.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/RegistriesManager.sol#L5

global import of path ./interfaces/IRegistry.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/RegistriesManager.sol#L11

Immutable variables name are set to be in capitalized SNAKE_CASE

scripts/proposals/proposal_03_service_registry_change_drainer_goerli.js#L12

'provider' is assigned a value but never used

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V1.1.7 internal audit4.1 #121

V1.1.7 internal audit4.1 #121

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...