refactor and test: update same address multisig implementation #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariapiamo
reviewed
Oct 11, 2023
| revert ZeroValue(); | ||
| } | ||
|
|
||
| // Record provided multisig proxy bytecode hashes |
There was a problem hiding this comment.
we need to update the deployment scripts with these hashes
| GnosisSafeSameAddressMultisig.deploy([bytes32Zero]) | ||
| ).to.be.revertedWithCustomError(gnosisSafeSameAddressMultisig, "ZeroValue"); | ||
| }); | ||
|
|
There was a problem hiding this comment.
we should also update the tests regarding the GnosisSafeSameAddressMultisig.create() method, no?
There was a problem hiding this comment.
There is one in the serviceStaking testing
mariapiamo
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GnosisSafeSameAddressMultisigimplementation to check for the proxy;