feat: concept for accounting on ai agent mechs when staking #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Oct 13, 2023
•
kupermind
commented
- Accounting for AI agent mechs specifics when staking services interacting with them.
| @@ -161,13 +163,14 @@ abstract contract ServiceStakingBase is ERC721TokenReceiver, IErrorsRegistries { | |||
|
|
|||
| /// @dev ServiceStakingBase constructor. | |||
| /// @param _stakingParams Service staking parameters. | |||
| /// @param _numNonces Number of service multisig nonces depending on implementation. | |||
There was a problem hiding this comment.
Not sure I follow why we need this
There was a problem hiding this comment.
Refactored, no need for that now.
| nonces[1] = IAgentMech(agentMech).getRequestsCount(multisig); | ||
| } | ||
|
|
||
| /// @dev Checks if the service multisig liveness ratio passes the defined liveness threshold. |
There was a problem hiding this comment.
Docstring could explain what exactly liveness means in this context / implementation
| function getRequestsCount(address account) external view returns (uint256 requestsCount); | ||
| } | ||
|
|
||
| /// @title ServiceStakingMechAgentNativeToken - Smart contract for staking a service with the service interacting wiht |
There was a problem hiding this comment.
Suggested change
| /// @title ServiceStakingMechAgentNativeToken - Smart contract for staking a service with the service interacting wiht | |
| /// @title ServiceStakingMechAgentNativeToken - Smart contract for staking a service with the service interacting with |
DavidMinarsch
approved these changes
Oct 13, 2023
kupermind
changed the title
mariapiamo
approved these changes
Oct 16, 2023
doc: intenal audit included Mech and GnosisSameAddress
refactor and chore: addressing internal audit comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.