feat: add hash-checkpoint contract #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xArdi
reviewed
Nov 23, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 99.73% 99.15% -0.58%
==========================================
Files 19 20 +1
Lines 1508 1541 +33
Branches 283 287 +4
==========================================
+ Hits 1504 1528 +24
- Misses 4 13 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kupermind
reviewed
Nov 23, 2023
| pragma solidity ^0.8.21; | ||
|
|
||
| /// @title Hash Checkpoint - Smart contract for checkpointing IPFS hashes on-chain | ||
| /// @author Aleksandr Kuperman - <[email protected]> |
There was a problem hiding this comment.
We need to change the author :D
There was a problem hiding this comment.
Lol you'll be the author eventually
kupermind
reviewed
Nov 23, 2023
|
|
||
| /// @dev Changes the owner address. | ||
| /// @param newOwner Address of a new owner. | ||
| function changeOwner(address newOwner) external virtual { |
There was a problem hiding this comment.
Probably no need to be a virtual function? For all of them below as well.
There was a problem hiding this comment.
I guess no harm
kupermind
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.