Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and test: adding check for service bonds #146

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

kupermind
Copy link
Collaborator

  • Adding check for service bonds;
  • Adding a parameter for a minimum number of staking periods;
  • Modifying tests.

@kupermind kupermind requested review from 77ph and mariapiamo January 23, 2024 18:59
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6e825e2) 99.25% compared to head (aace8ba) 99.13%.
Report is 3 commits behind head on main.

Files Patch % Lines
contracts/staking/ServiceStakingBase.sol 94.73% 1 Missing ⚠️
contracts/staking/ServiceStakingToken.sol 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   99.25%   99.13%   -0.12%     
==========================================
  Files          20       20              
  Lines        1606     1620      +14     
  Branches      296      300       +4     
==========================================
+ Hits         1594     1606      +12     
- Misses         12       14       +2     
Flag Coverage Δ
unittests 99.13% <92.59%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kupermind kupermind merged commit 551027b into main Jan 23, 2024
2 checks passed
@kupermind kupermind deleted the staking_bond branch January 23, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants