-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: make mech marketplace deliver work #61
base: main
Are you sure you want to change the base?
WIP: make mech marketplace deliver work #61
Conversation
mech_client/marketplace_interact.py
Outdated
@@ -90,9 +116,9 @@ def send_marketplace_request( # pylint: disable=too-many-arguments,too-many-loc | |||
method_name = "request" | |||
methord_args = { | |||
"data": v1_file_hash_hex_truncated, | |||
"priorityMech": ADDRESS_ZERO, | |||
"priorityMech": "0x2C347caF85475793A19B18925faA3BEbEa27cd5c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want this to be configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value should be a global var like ADDRESS_ZERO
, makes it more readable, and easier to change later if need be.
mech_client/marketplace_interact.py
Outdated
@@ -215,7 +320,8 @@ def marketplace_interact( | |||
gas_limit=mech_config.gas_limit, | |||
price=price, | |||
prompt=prompt, | |||
tool=tool, | |||
# @todo better fetch and verify tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdym? Verify how/what?
mech_client/marketplace_interact.py
Outdated
# -*- coding: utf-8 -*- | ||
# ------------------------------------------------------------------------------ | ||
# | ||
# Copyright 2023 Valory AG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 2024
No description provided.