Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: make mech marketplace deliver work #61

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

KahanMajmudar
Copy link
Collaborator

No description provided.

@KahanMajmudar KahanMajmudar requested a review from 0xArdi December 13, 2024 15:26
@KahanMajmudar KahanMajmudar marked this pull request as ready for review December 16, 2024 13:11
@@ -90,9 +116,9 @@ def send_marketplace_request( # pylint: disable=too-many-arguments,too-many-loc
method_name = "request"
methord_args = {
"data": v1_file_hash_hex_truncated,
"priorityMech": ADDRESS_ZERO,
"priorityMech": "0x2C347caF85475793A19B18925faA3BEbEa27cd5c",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this to be configurable

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value should be a global var like ADDRESS_ZERO, makes it more readable, and easier to change later if need be.

@@ -215,7 +320,8 @@ def marketplace_interact(
gas_limit=mech_config.gas_limit,
price=price,
prompt=prompt,
tool=tool,
# @todo better fetch and verify tool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym? Verify how/what?

# -*- coding: utf-8 -*-
# ------------------------------------------------------------------------------
#
# Copyright 2023 Valory AG
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2024

@KahanMajmudar KahanMajmudar requested a review from 0xArdi December 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants