Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created base mech repo and removed all unnecessary deps #264

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

KahanMajmudar
Copy link
Collaborator

@KahanMajmudar KahanMajmudar commented Nov 14, 2024

Proposed changes

Creates a base mech repo with minimal deps and a single tool. This will allow the users to fork the repo and create their own mech and tools. The motivation for this change is, since the dependencies are strict, it would not allow the users to have different tools with conflicting package versions. This change allows the users to fork the repo and have seperate tools with their own required dependencies.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

mints/01.json Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files under mints that reference packages that are to stay in the base mech repo should be kept.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and those that need to be on the mech-predict repo, we can remove from here.

@@ -19,65 +19,25 @@ python = ">=3.10,<3.12"
open-autonomy = "==0.18.2"
openai = "==1.30.2"
requests = "==2.28.1"
mech-client = "==0.2.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

py-multibase = "==1.0.3"
py-multicodec = "==0.2.1"
grpcio = "==1.53.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here?

pyproject.toml Outdated
Comment on lines 25 to 26
grpcio = "==1.53.0"
asn1crypto = "<1.5.0,>=1.4.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a core dep too

pyproject.toml Outdated
open-aea-ledger-ethereum = "==1.59.0"
open-aea-ledger-cosmos = "==1.59.0"
protobuf = "<4.25.0,>=4.21.6"
hypothesis = "==6.21.6"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for tests, not related to tools packages

pyproject.toml Outdated
open-aea-test-autonomy = "==0.18.2"
web3 = "<7,>=6.0.0"
ipfshttpclient = "==0.8.0a2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these removed here too

pyproject.toml Outdated
websocket_client = "<1,>=0.32.0"
toml = "==0.10.2"
googlesearch-python = "==1.2.3"
beautifulsoup4 = "==4.12.2"
google-api-python-client = "==2.95.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can get rid of this

pyproject.toml Outdated
pytest = "==7.2.1"
jsonschema = "<4.4.0,>=4.3.0"
spacy = "==3.7.2"
pandas = "^2.1.1"
tiktoken = "==0.7.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can get rid of this

pyproject.toml Outdated
Comment on lines 33 to 45
ipfshttpclient = "==0.8.0a2"
open-aea-cli-ipfs = "==1.59.0"
pytest-asyncio = "*"
aiohttp = "<4.0.0,>=3.8.5"
certifi = "*"
multidict = "*"
ecdsa = ">=0.15"
eth_typing = "*"
hexbytes = "*"
packaging = "*"
py-ecc = "==6.0.0"
pytz = "==2022.2.1"
typing_extensions = ">=3.10.0.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea with this removal of dependencies is to get rid of all dependencies that are tool specific.
Dependencies that are here are core dependencies (check Pipfile).

Also, remember to remove them from the skill.yaml (if present on any) and aea-config.yaml.

@0xArdi 0xArdi changed the base branch from main to develop November 15, 2024 12:08
@0xArdi 0xArdi merged commit 911004c into develop Nov 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants