-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created base mech repo and removed all unnecessary deps #264
Conversation
mints/01.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
files under mints
that reference packages that are to stay in the base mech repo should be kept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and those that need to be on the mech-predict repo, we can remove from here.
@@ -19,65 +19,25 @@ python = ">=3.10,<3.12" | |||
open-autonomy = "==0.18.2" | |||
openai = "==1.30.2" | |||
requests = "==2.28.1" | |||
mech-client = "==0.2.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this?
py-multibase = "==1.0.3" | ||
py-multicodec = "==0.2.1" | ||
grpcio = "==1.53.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here?
pyproject.toml
Outdated
grpcio = "==1.53.0" | ||
asn1crypto = "<1.5.0,>=1.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is a core dep too
pyproject.toml
Outdated
open-aea-ledger-ethereum = "==1.59.0" | ||
open-aea-ledger-cosmos = "==1.59.0" | ||
protobuf = "<4.25.0,>=4.21.6" | ||
hypothesis = "==6.21.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed for tests, not related to tools packages
pyproject.toml
Outdated
open-aea-test-autonomy = "==0.18.2" | ||
web3 = "<7,>=6.0.0" | ||
ipfshttpclient = "==0.8.0a2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of these removed here too
pyproject.toml
Outdated
websocket_client = "<1,>=0.32.0" | ||
toml = "==0.10.2" | ||
googlesearch-python = "==1.2.3" | ||
beautifulsoup4 = "==4.12.2" | ||
google-api-python-client = "==2.95.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can get rid of this
pyproject.toml
Outdated
pytest = "==7.2.1" | ||
jsonschema = "<4.4.0,>=4.3.0" | ||
spacy = "==3.7.2" | ||
pandas = "^2.1.1" | ||
tiktoken = "==0.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can get rid of this
pyproject.toml
Outdated
ipfshttpclient = "==0.8.0a2" | ||
open-aea-cli-ipfs = "==1.59.0" | ||
pytest-asyncio = "*" | ||
aiohttp = "<4.0.0,>=3.8.5" | ||
certifi = "*" | ||
multidict = "*" | ||
ecdsa = ">=0.15" | ||
eth_typing = "*" | ||
hexbytes = "*" | ||
packaging = "*" | ||
py-ecc = "==6.0.0" | ||
pytz = "==2022.2.1" | ||
typing_extensions = ">=3.10.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea with this removal of dependencies is to get rid of all dependencies that are tool specific.
Dependencies that are here are core dependencies (check Pipfile).
Also, remember to remove them from the skill.yaml
(if present on any) and aea-config.yaml
.
Proposed changes
Creates a base mech repo with minimal deps and a single tool. This will allow the users to fork the repo and create their own mech and tools. The motivation for this change is, since the dependencies are strict, it would not allow the users to have different tools with conflicting package versions. This change allows the users to fork the repo and have seperate tools with their own required dependencies.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...