Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc #266

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: misc #266

merged 1 commit into from
Nov 18, 2024

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented Nov 18, 2024

Fixes

This PR fixes misc issues noticed on prod.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@0xArdi 0xArdi requested a review from KahanMajmudar November 18, 2024 12:22
Copy link
Collaborator

@KahanMajmudar KahanMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xArdi 0xArdi merged commit 5f0fc42 into develop Nov 18, 2024
6 of 7 checks passed
@0xArdi 0xArdi deleted the fix/misc-marketplace branch November 18, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants