Fix balances getters #127
Merged
Fix balances getters #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
requested review from
truemiller and
mohandast52
and removed request for
truemiller
mohandast52
approved these changes
May 24, 2024
truemiller
approved these changes
May 24, 2024
Tanya-atatakai
force-pushed
the
tanya/reconsider-total-blance
branch
from
153e496 to
f929b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves: there are cases where we need to check balance of the EOA address (e.g. before safe or backup address creation) or to check safe address balance (e.g. when showing "needs funds" alert or low-gas states) - but at the moment in all such places we check total sum of all addresses' balances.
Some context: when we create an account, the EOA address is created which is needed for creating other addresses. we then:
so e.g. at the moment when we display low-gas alert (dot), we take into account the remaining on EOA (~0.48) but our safe address can have 0 xDai, we have total of 0.48 < 0.1 (low gas value) and display that everything is fine but we should show that the safe needs funds.