Support for deleting deployments #15
Conversation
| chain_data?: ChainData; | ||
| ledger: LedgerConfig; | ||
| chain_data: ChainData; | ||
| active: boolean; |
There was a problem hiding this comment.
@truemiller only display the service with active set to true on the front end
| @_operate.command(name="prune") | ||
| def _prune( | ||
| home: Annotated[ | ||
| Path, params.Directory(long_flag="--home", help="Home directory") | ||
| ] = None, | ||
| ) -> None: | ||
| """Delete unused/cached data.""" |
There was a problem hiding this comment.
@dvilelaf When installing the operate app, we will install operate as a CLI tool as well so that users can run operate prune to delete the cache and unused deployments
There was a problem hiding this comment.
So we're requiring users to run a command? Not sure if that bodes well with the idea of the app. If users don't run this command, what will happen? Old deployments will just be there?
| # except Exception as e: | ||
| # print(e) | ||
|
|
||
| old.delete({}) |
There was a problem hiding this comment.
Is this possible now? What about thr superuser permissions issue?
There was a problem hiding this comment.
If we get permission error we set service as in-active and it won't show up on the front-end and the user can perform clean up using operate prune
There was a problem hiding this comment.
Does this command require sudo password? Can I confirm that the superuser permission only happens on Linux?
There was a problem hiding this comment.
yes, this required sudo. it does not happen on mac, we haven't tested on windows so cannot say
|
small question before approval, are there are any deployment conflicts when redeploying a deleted agent that has only been set as inactive? |
Yes, the service in inactive status should not be deployed. Most probably it won't work but avoid requesting a deployment for an inactive service |
Blocking the user from redeploying a deleted deployment is bad for UX. We should discuss with others to find a better solution. Is it possible to chmod the directory to allow for deletion? |
No description provided.