feat: Update app name on topbar based on version #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mohandast52
commented
May 29, 2024
mohandast52
commented
Tanya-atatakai
approved these changes
May 30, 2024
| <Text>Pearl (alpha)</Text> | ||
| <Text> | ||
| Pearl (alpha) | ||
| {store?.storeState?.appVersion?.includes('rc') ? '' : ' (staging)'} |
There was a problem hiding this comment.
won't we be able to get it from process.env.IS_STAGING?
There was a problem hiding this comment.
Yes, we can. I'm considering removing it completely. I'll update here once I've discussed it with Josh.
mohandast52
commented
May 30, 2024
|
|
||
| const versionName = useMemo(() => { | ||
| const releaseType = store?.storeState?.releaseType; | ||
| if (releaseType === 'draft') return ' (staging)'; |
There was a problem hiding this comment.
@Tanya-atatakai, we can't use .env files because they aren't exposed here, so we used this technique instead.
@truemiller, do you think the appVersion is unnecessary and won't need renaming?
There was a problem hiding this comment.
yeah, not sure we need appVersion is store..
can probably just a expose constant through electron api
truemiller
reviewed
Jun 3, 2024
truemiller
reviewed
Jun 3, 2024
truemiller
reviewed
Jun 3, 2024
electron/main.js
Outdated
| setupStoreIpc(ipcMain, mainWindow); | ||
| const storeInitialValues = { | ||
| appVersion: app.getVersion(), | ||
| releaseType: process.env.IS_STAGING ? 'draft' : 'release', |
There was a problem hiding this comment.
Suggested change
| releaseType: process.env.IS_STAGING ? 'draft' : 'release', | |
| releaseType: 'draft', |
…ants/publishOptions.js and update olas-operate-middleware version to '0.1.0rc26' in electron/install.js
angrybayblade
approved these changes
Jun 3, 2024
truemiller
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.